Merge pull request #279 from ray-di/remove_implicit_untarget_bindings

Remove implicit untarget bindings
ray-di · Dec 6, 2022 · 53bb56b · 53bb56b
2 parents 416bc48 + 0b6dbdb
commit 53bb56b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 45 deletions.
diff --git a/src/di/AssistedInterceptor.php b/src/di/AssistedInterceptor.php
@@ -17,6 +17,7 @@
 use function class_exists;
 use function in_array;
 use function interface_exists;
+use function is_string;
 use function parse_str;
 
 /**
@@ -96,8 +97,8 @@ private function getName(ReflectionMethod $method, ReflectionParameter $paramete
 
         parse_str($named->value, $names);
         $paramName = $parameter->getName();
-        if (isset($names[$paramName])) {
-            return (string) $names[$paramName];
+        if (isset($names[$paramName]) && is_string($names[$paramName])) {
+            return $names[$paramName];
         }
 
         return Name::ANY;

diff --git a/src/di/Untarget.php b/src/di/Untarget.php
@@ -31,10 +31,6 @@ public function __invoke(Container $container, Bind $bind): void
         $bound->setScope($this->scope);
         $bind->setBound($bound);
         $container->add($bind);
-        $constructor = $this->class->getConstructor();
-        if ($constructor) {
-            (new UntargetedBind())($container, $constructor);
-        }
     }
 
     public function setScope(string $scope): void

diff --git a/src/di/UntargetedBind.php b/src/di/UntargetedBind.php
diff --git a/tests/di/InjectorTest.php b/tests/di/InjectorTest.php
@@ -152,7 +152,12 @@ public function testGetConcreteClass(): void
 
     public function testGetConcreteHavingDependency(): void
     {
-        $injector = new Injector();
+        $injector = new Injector(new class extends AbstractModule{
+            protected function configure()
+            {
+                $this->bind(FakeRobot::class);
+            }
+        });
         $team = $injector->getInstance(FakeRobotTeam::class);
         $this->assertInstanceOf(FakeRobotTeam::class, $team);
         $this->assertInstanceOf(FakeRobot::class, $team->robot1);