Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix psalm conditional type #249

Merged
merged 4 commits into from
Nov 6, 2021
Merged

Fix psalm conditional type #249

merged 4 commits into from
Nov 6, 2021

Conversation

koriym
Copy link
Member

@koriym koriym commented Nov 5, 2021 •
edited

  • Fix InjectorInterface psalm conditional type
  • Container implements InjectorInterface
  • Add type test

@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited

Codecov Report

Merging #249 (6d8c1ee) into 2.x (fa83eea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                 2.x      #249   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       317       317           
===========================================
  Files             36        36           
  Lines            819       819           
===========================================
  Hits             819       819
Impacted Files Coverage Δ
src/di/Injector.php 100.00% <ø> (ø)
src/di/Container.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa83eea...6d8c1ee. Read the comment docs.

@koriym koriym force-pushed the fix-conditional-type branch 4 times, most recently from 1f82ea0 to 587864e Compare November 5, 2021 21:16
@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym merged commit 2066c54 into ray-di:2.x Nov 6, 2021
@koriym koriym deleted the fix-conditional-type branch November 6, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@koriym