Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Named attribute in property #254

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Allow Named attribute in property #254

merged 3 commits into from
Feb 8, 2022

Conversation

koriym
Copy link
Member

@koriym koriym commented Feb 7, 2022

PHP8のコンストラクタプロモーションでphpstanやpsalmなどの静的解析が誤検知するのを防ぎます。

This is to prevent static analysis such as phpstan and psalm from false positives in PHP8 constructor promotion.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #254 (c8f667e) into 2.x (0c72dd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                 2.x      #254   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       317       317           
===========================================
  Files             36        36           
  Lines            819       819           
===========================================
  Hits             819       819           
Impacted Files Coverage Δ
src/di/Di/Named.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c72dd5...c8f667e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym merged commit 310ed1d into ray-di:2.x Feb 8, 2022
@koriym koriym deleted the named branch February 8, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants