Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ModuleMerger #258

Merged
merged 7 commits into from
Feb 19, 2022
Merged

Add ModuleMerger #258

merged 7 commits into from
Feb 19, 2022

Conversation

koriym
Copy link
Member

@koriym koriym commented Feb 17, 2022

Closes #257

@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited

Codecov Report

Merging #258 (d165790) into 2.x (aebdbdc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                 2.x      #258   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       317       320    +3     
===========================================
  Files             36        37    +1     
  Lines            819       826    +7     
===========================================
+ Hits             819       826    +7
Impacted Files Coverage Δ
src/di/Injector.php 100.00% <100.00%> (ø)
src/di/ModuleMerger.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebdbdc...d165790. Read the comment docs.

@NaokiTsuchiya
Copy link
Member

resoleved のスレッドに書いてしまったので。

#258 (comment)

@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
7.3% 7.3% Duplication

@koriym
Copy link
Member Author

koriym commented Feb 19, 2022

resoleved のスレッドに書いてしまったので。

#258 (comment)

対処しました！

@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym merged commit 382550a into ray-di:2.x Feb 19, 2022
@koriym koriym deleted the array_modules branch February 19, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaokiTsuchiya NaokiTsuchiya NaokiTsuchiya approved these changes

@kawanamiyuu kawanamiyuu Awaiting requested review from kawanamiyuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injector receives an array of modules
2 participants
@koriym @NaokiTsuchiya