Provider injection with Set attribute #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #262 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 320 324 +4
===========================================
Files 37 40 +3
Lines 826 842 +16
===========================================
+ Hits 826 842 +16
Continue to review full report at Codecov.
|
NaokiTsuchiya
approved these changes
Mar 1, 2022
|
動的ファクトリー生成のインジェクトがたったこれだけで書けるのかという |
koriym
changed the title
koriym
commented
Mar 2, 2022
src/di/Injector.php
Outdated
| @@ -38,6 +38,7 @@ public function __construct($module = null, string $tmpDir = '') | |||
|
|
|||
| $module = $module ?? new NullModule(); | |||
| $module->install(new AssistedModule()); | |||
| $module->install(new InjectingProviderModule()); | |||
NaokiTsuchiya
suggested changes
Mar 2, 2022
Co-authored-by: Naoki Tsuchiya <ntsuchiya1105@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
NaokiTsuchiya
approved these changes
Mar 2, 2022
NaokiTsuchiya
approved these changes
Mar 2, 2022
NaokiTsuchiya
approved these changes
Mar 2, 2022
NaokiTsuchiya
approved these changes
Mar 2, 2022
NaokiTsuchiya
approved these changes
Mar 2, 2022
NaokiTsuchiya
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the injection of lazily instantiated objects.
closes #261
* "パラメーターのアノテーション"は無いのでパラメーター指定もなく、インジェクションポイントからアノテーションを読みに行くのも煩雑で一旦（リクエストない限り）PHP8のアトリビュートのみ対応
Provider injection
Multibinder