Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "nikic/php-parser" dependency #288

Closed
wants to merge 2 commits into from
Closed

Conversation

koriym
Copy link
Member

@koriym koriym commented Apr 23, 2024

The "nikic/php-parser" dependency is no longer needed in our

Summary by CodeRabbit

  • Chores
    • Updated PHP version from 8.1 to 8.3 in workflow configurations.
  • Refactor
    • Removed outdated dependencies from the project configuration.

The "nikic/php-parser" dependency is no longer needed in our
Copy link

coderabbitai bot commented Apr 23, 2024

Walkthrough

The recent updates involve upgrading the PHP version from 8.1 to 8.3 in various GitHub workflow configurations and simplifying the tooling by removing cs2pr in one of the workflows. Additionally, the project's dependencies have been streamlined by removing koriym/printo and nikic/php-parser from composer.json.

Changes

Files Change Summary
.github/workflows/.../coding-standards.yml Updated PHP version from 8.1 to 8.3
.github/workflows/.../demo-php8.yml Updated PHP version from 8.1 to 8.3, removed cs2pr
.github/workflows/.../static-analysis.yml Updated PHP version from 8.1 to 8.3
composer.json Removed dependencies koriym/printo and nikic/php-parser

Poem

🐇✨
In the land of code and night,
A rabbit hopped with sheer delight.
PHP eight point three, now in sight,
Tools and deps, they trim just right.
Hop, hop, hop, on to the light!


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bb0e91b and 594fdf8.
Files selected for processing (4)
  • .github/workflows/coding-standards.yml (1 hunks)
  • .github/workflows/demo-php8.yml (1 hunks)
  • .github/workflows/static-analysis.yml (1 hunks)
  • composer.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • composer.json
Additional comments not posted (3)
.github/workflows/static-analysis.yml (1)

12-12: Update of PHP version to 8.3 appears correctly implemented.

Please ensure that all static analysis tools used in the workflow are compatible with PHP 8.3.

.github/workflows/coding-standards.yml (1)

12-12: Update of PHP version to 8.3 appears correctly implemented.

Please ensure that all coding standards tools used in the workflow are compatible with PHP 8.3.

.github/workflows/demo-php8.yml (1)

19-19: Update of PHP version to 8.3 and tool setting adjustment appear correctly implemented.

Please verify that the removal of cs2pr aligns with your project's reporting requirements for coding standards violations.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

The PHP version used in the GitHub workflows for demo-php8, coding-stand
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@koriym koriym marked this pull request as ready for review April 23, 2024 11:57
@koriym koriym closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant