Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #14

Merged
merged 5 commits into from
Mar 9, 2015
Merged

Clean up #14

merged 5 commits into from
Mar 9, 2015

Conversation

koriym
Copy link
Member

@koriym koriym commented Mar 4, 2015

cleanup for release

@koriym
Copy link
Member Author

koriym commented Mar 4, 2015

新しくより細かい.php_cs適用しました。

@koriym
Copy link
Member Author

koriym commented Mar 4, 2015

mergeちょっと待ってくださいね

@kawanamiyuu
Copy link
Member

👍

@koriym
Copy link
Member Author

koriym commented Mar 4, 2015

demo codeを忘れてないですか？

@kawanamiyuu
Copy link
Member

他のRay moduleに倣ってdocs/demo/run(_by_app_module).phpを用意しましたが、そのスクリプトを叩いたら本当にOAuthしちゃうくらいのものがあったほうが良いということですよね。。

@koriym
Copy link
Member Author

koriym commented Mar 4, 2015

docs/ないですよね？（何か勘違いしてるでしょうか

@kawanamiyuu
Copy link
Member

あ、#12 は refactor/simplify-module ブランチで作業しています

@koriym
Copy link
Member Author

koriym commented Mar 5, 2015

本当にOAuth

そうです。今のようなテストコードのようなものではなく、実際の動作が確認できるデモです。
キーを設定してスクリプトを実行(ビルトインサーバー？）すると遷移を含め動作が確認できるものがいいのではないでしょうか？

@kawanamiyuu
Copy link
Member

そうですね。了解です、追加します 👍

@koriym
Copy link
Member Author

koriym commented Mar 5, 2015

👍

@kawanamiyuu
Copy link
Member

#12 refactor/simplify-module を develop にマージしました

@kawanamiyuu
Merge branch 'develop' into cleanup
441187d 
Conflicts:
	src/ClientFactory.php
	src/Facebook/FacebookInject.php
	src/Facebook/FacebookModule.php
	tests/ClientFactoryTest.php
	tests/Facebook/FacebookModuleTest.php
@kawanamiyuu
apply .php_cs
c490cc9
@kawanamiyuu
update phpunit.xml.dist
42651e7
kawanamiyuu added a commit that referenced this pull request Mar 9, 2015
@kawanamiyuu
Merge pull request #14 from ray-di/cleanup
ae54cec 
Clean up
@kawanamiyuu kawanamiyuu merged commit ae54cec into develop Mar 9, 2015
@kawanamiyuu kawanamiyuu deleted the cleanup branch March 9, 2015 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koriym @kawanamiyuu