Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] latest gofumpt cause test issue #597

Closed
2 tasks done
wilsonwang371 opened this issue Sep 27, 2022 · 1 comment · Fixed by #596
Closed
2 tasks done

[Bug] latest gofumpt cause test issue #597

wilsonwang371 opened this issue Sep 27, 2022 · 1 comment · Fixed by #596
Labels
bug Something isn't working ci P0 Critical issue that should be fixed ASAP

Comments

@wilsonwang371
Copy link
Collaborator

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ci

What happened + What you expected to happen

since we always use the latest gofumpt verison. recent verison upgrade made our ci tests fail. We need to use a verified version of gofumpt instead of always using latest.

Reproduction script

now the ci tests always fail.

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@wilsonwang371 wilsonwang371 added bug Something isn't working ci P0 Critical issue that should be fixed ASAP labels Sep 27, 2022
@wilsonwang371 wilsonwang371 mentioned this issue Sep 27, 2022
Merged
4 tasks
@wilsonwang371 wilsonwang371 linked a pull request Sep 27, 2022 that will close this issue
[CI]use fixed version of gofumpt #596
Merged
4 tasks
@wilsonwang371
Copy link
Collaborator Author

FYI: @Jeffwan @scarlet25151 @DmitriGekhtman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ci P0 Critical issue that should be fixed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI]use fixed version of gofumpt wilsonwang371/kuberay
1 participant
@wilsonwang371