Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]use fixed version of gofumpt #596

Merged

Conversation

wilsonwang371
Copy link
Collaborator

@wilsonwang371 wilsonwang371 commented Sep 27, 2022

Why are these changes needed?

With gofumpt version upgraded, there is some issue installing it. We now need to use a fixed version of gofumpt to avoid test issues from external.

Related issue number

#597

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@wilsonwang371 wilsonwang371 changed the title use fixed version of gofumpt [CI]use fixed version of gofumpt Sep 27, 2022
@wilsonwang371 wilsonwang371 added ci P0 Critical issue that should be fixed ASAP labels Sep 27, 2022
@wilsonwang371 wilsonwang371 linked an issue Sep 27, 2022 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix!

@DmitriGekhtman DmitriGekhtman merged commit a257836 into ray-project:master Sep 27, 2022
@wilsonwang371 wilsonwang371 deleted the wilson/fix-gofumpt-version branch September 27, 2022 20:56
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
With gofumpt version upgraded, there is some issue installing it. We now need to use a fixed version of gofumpt to avoid test issues from external.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci P0 Critical issue that should be fixed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] latest gofumpt cause test issue
2 participants