Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Verify operator image building in CI #69

Closed
1 of 2 tasks
Jeffwan opened this issue Oct 16, 2021 · 2 comments
Closed
1 of 2 tasks

[Feature] Verify operator image building in CI #69

Jeffwan opened this issue Oct 16, 2021 · 2 comments
Labels
ci enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.2.0 release

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Oct 16, 2021

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently we only run make build in CI to verify binary build works or not. This won't cover any changes on Dockerfile etc.

Use case

Catch changes to Dockerfile and container related commands, etc

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the enhancement New feature or request label Oct 16, 2021
@Jeffwan Jeffwan mentioned this issue Oct 16, 2021
Closed
2 tasks
@Jeffwan Jeffwan added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 16, 2021
@Jeffwan Jeffwan added this to the v0.2.0 release milestone Oct 19, 2021
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jan 17, 2022

/cc @wilsonwang371

@Jeffwan Jeffwan added the ci label Jan 17, 2022
wilsonwang371 added a commit to wilsonwang371/kuberay that referenced this issue Jan 17, 2022
@wilsonwang371
fix ray-project#69
970ecaf
@wilsonwang371 wilsonwang371 mentioned this issue Jan 17, 2022
Merged
4 tasks
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jan 18, 2022

Thanks for the great work!

@Jeffwan Jeffwan closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.2.0 release
Development

No branches or pull requests
1 participant
@Jeffwan