Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0 python client library validation #1006

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

jasoonn
Copy link
Contributor

@jasoonn jasoonn commented Apr 4, 2023

Why are these changes needed?

  1. Verify the built clusters in examples of the python client library are functional.
  2. Remove init containers in template because there will be default init container in v0.5.0(#973).

Basic flow for verification cluster

Cover the following examples: use-builder.py, use-director.py, use-raw-config_map_with-api.py, use-raw-with-api.py, use-utils.py.

  1. Setup Ray operator

    kind create cluster
    helm repo add kuberay https://ray-project.github.io/kuberay-helm/ 
    helm repo update
    helm install kuberay-operator kuberay/kuberay-operator --version 0.5.0-rc.0
    
  2. Comment out the cluster deletion section in the python file.

    if "items" in kube_ray_list:
    for cluster in kube_ray_list["items"]:
    print("deleting raycluster = {}".format(cluster["metadata"]["name"]))
    my_kuberay_api.delete_ray_cluster(
    name=cluster["metadata"]["name"],
    k8s_namespace=cluster["metadata"]["namespace"],
    )

  3. Run the example
    python3 use-builder.py

  4. Submit a simple ray job to the cluster
    image

  5. Port forwarding
    image

  6. Check cluster dashboard
    image

Additional steps for complete-example.py

Because there is an update of cluster in complete-example.py, we need to verify whether the cluster information is modified as expected. Hence, input() is put before the call of modification cluster API(line 62 in complete-example.py) to pause the execution of the example, and two Ray jobs are submitted before and after the modification to see whether the cluster resource is updated as exected.
Screen Shot 2023-04-03 at 9 18 24 PM

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 merged commit 9dd516d into ray-project:master Apr 4, 2023
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Apr 4, 2023
Release v0.5.0 python client library validation
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Release v0.5.0 python client library validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants