Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update nav to include missing files and reorganize nav #1011

Merged
merged 7 commits into from
Apr 5, 2023

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

There were some doc files that were missing from the nav so were hard or impossible to access from the front page of the docs. This PR adds them to the nav and groups them better to avoid having a long list of files.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni
Copy link
Contributor Author

This is a summary of the missing files: 24c1160

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is very helpful!

@kevin85421
Copy link
Member

kevin85421 commented Apr 5, 2023

This PR has no relationship with CI tests, so it's OK to merge this PR before the CI finishes.

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni architkulkarni merged commit 6e1f1bd into ray-project:master Apr 5, 2023
16 checks passed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…ject#1011)

There were some doc files that were missing from the nav so were hard or impossible to access from the front page of the docs. This PR adds them to the nav and groups them better to avoid having a long list of files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants