Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm][ray-cluster] Fix parsing envFrom field in additionalWorkerGroups #1039

Merged
merged 2 commits into from
Apr 24, 2023
Merged

[Helm][ray-cluster] Fix parsing envFrom field in additionalWorkerGroups #1039

merged 2 commits into from
Apr 24, 2023

Conversation

anovv
Copy link
Contributor

@anovv anovv commented Apr 20, 2023

Should fix #1038

Related issue number

(#1038)

Checks

  • Testing Strategy
    • Manual tests

@kevin85421
Copy link
Member

Hi, would you mind fixing the lint errors? You can check this doc to reproduce the lint error on your laptop. Thanks!

@anovv
Copy link
Contributor Author

anovv commented Apr 24, 2023

@kevin85421 thanks for review! I believe lint errors should be fixed now

kevin85421
kevin85421 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this PR by the following commands.

# path: helm-chart/ray-cluster
# (1) Set `additionalWorkerGroups.smallGroup.disabled` to false
# (2) Add `additionalWorkerGroups.smallGroup.envFrom`
helm template . | tee log

# Check log

@kevin85421 kevin85421 merged commit 831b55b into ray-project:master Apr 24, 2023
16 checks passed
@kevin85421 kevin85421 mentioned this pull request Apr 28, 2023
Open
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@anovv
[Helm][ray-cluster] Fix parsing envFrom field in additionalWorkerGrou…
0212be9 
…ps (ray-project#1039)

Fix parsing envFrom field in additionalWorkerGroups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm] ray-cluster chart fails to parse envFrom field in additionalWorkerGroups
2 participants
@anovv @kevin85421