Align Init Container's ImagePullPolicy with Ray Container's ImagePullPolicy #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…Policy (ray-project#1080) Align Init Container's ImagePullPolicy with Ray Container's ImagePullPolicy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
According to this discussion, users may need to adjust the ImagePullPolicy of the init container, which is currently set to
PullIfNotPresent.This PR aligns the init container's ImagePullPolicy with the ImagePullPolicy of the ray container.
Related issue number
None
Checks
Manual Testing Procedure:
imagePullPolicy: Alwaysto theworkerGroupSpecs[0].template.spec.containers[0]in theray-cluster.complete.yamlfile(can be found here)Here is an image showing the expected output: