Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename instances of rayiov1alpha1 to rayv1alpha1 #1112

Merged
merged 1 commit into from
May 30, 2023

Conversation

anishasthana
Copy link
Contributor

@anishasthana anishasthana commented May 25, 2023

cc @kevin85421 the PR is ready for review. I deployed using the instructions in development.md. I tested with the smallest sample: https://raw.githubusercontent.com/ray-project/kuberay/master/ray-operator/config/samples/ray-cluster.mini.yaml

Why are these changes needed?

Related issue number

Closed #1079

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests

@anishasthana
Copy link
Contributor Author

Closes #1079

@anishasthana anishasthana changed the title WIP: Rename instances of rayiov1alpha1 to rayv1alpha1 feat: Rename instances of rayiov1alpha1 to rayv1alpha1 May 26, 2023
@kevin85421 kevin85421 self-requested a review May 28, 2023 18:41
…is/ray/v1alpha1

Rename instances of rayiov1alpha1 to rayv1alpha1
Update empty imports of github.com/ray-project/kuberay/ray-operator/apis/ray/v1alpha1 to be imported as rayv1alpha1

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anishasthana
Copy link
Contributor Author

/retest

@kevin85421 kevin85421 merged commit 7f77e46 into ray-project:master May 30, 2023
19 checks passed
@anishasthana anishasthana deleted the update_apis branch May 30, 2023 21:41
@anishasthana anishasthana restored the update_apis branch May 30, 2023 21:41
@anishasthana anishasthana deleted the update_apis branch May 30, 2023 21:41
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…is/ray/v1alpha1 (ray-project#1112)

Standardize imports of github.com/ray-project/kuberay/ray-operator/apis/ray/v1alpha1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Rename rayiov1alpha1 and rayv1alpha1 to v1alpha1
2 participants