Parametrize ray-operator makefile #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
reviewed
May 28, 2023
| @@ -82,12 +85,12 @@ run: manifests generate fmt vet ## Run a controller from your host. | |||
| go run ./main.go | |||
|
|
|||
| docker-image: ## Build image only | |||
| docker build -t ${IMG} . | |||
| ${ENGINE} build -t ${IMG} . | |||
There was a problem hiding this comment.
I am not familiar with podman. Does podman support the same commands as Docker?
There was a problem hiding this comment.
Yep, it's effectively a drop in replacement for Docker. Some people go as far as to add alias docker=podman onto their systems. The major difference between the two is that Docker runs as root, whereas podman runs rootless by default. So far I haven't noticed any issues due to running as rootless.
anishasthana
force-pushed
the
update_makefile
branch
4 times, most recently
from
2929cca
to
fed98c1
Compare
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
anishasthana
force-pushed
the
update_makefile
branch
from
fed98c1
to
7ac5425
Compare
kevin85421
approved these changes
Jun 1, 2023
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ay-project#1121) Parametrize ray operator makefile to support other container engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @kevin85421
Why are these changes needed?
This parametrizes the Makefile we are using to build and push Ray Operator images.
Related issue number
Closes #1116
Checks
I did not run manual tests as this is just modifying the makefile for image builds/push.