Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add helm update command to chart validation step in release process #1165

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Jun 13, 2023

Why are these changes needed?

Without this change, helm search repo kuberay may just print the old versions (at least, that's what it did for me.)

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni architkulkarni changed the title Add helm update command to chard validation step in release process Add helm update command to chart validation step in release process Jun 13, 2023
@architkulkarni architkulkarni changed the title Add helm update command to chart validation step in release process [Doc] Add helm update command to chart validation step in release process Jun 13, 2023
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@architkulkarni
Copy link
Contributor Author

Sample YAML failures are unrelated, this PR just updates the release process docs.

@architkulkarni architkulkarni merged commit b87480e into master Jun 14, 2023
15 of 18 checks passed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…rocess (ray-project#1165)

Without this change, helm search repo kuberay may just print the old versions (at least, that's what it did for me.)



Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@kevin85421 kevin85421 deleted the architkulkarni-patch-2 branch December 27, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants