[RayService] Change runtime env for e2e autoscaling test #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cindyz <cindyz@anyscale.com>
kevin85421
reviewed
Jun 21, 2023
| route_prefix: / | ||
| runtime_env: | ||
| working_dir: "https://github.com/ray-project/serve_workloads/archive/7a0daafdb86b55118534b04d122b1b79c9ae99f5.zip" | ||
| working_dir: "https://github.com/ray-project/test_dag/archive/7a0daafdb86b55118534b04d122b1b79c9ae99f5.zip" |
There was a problem hiding this comment.
In my understanding, the format of the URL is https://github.com/ray-project/${REPOSITORY}/archive/${COMMIT_OR_BRANCH}.zip. The test_dag repository may not have the commit 7a0daafdb86b55118534b04d122b1b79c9ae99f5. Perhaps we can consider using a branch instead, such as https://github.com/ray-project/test_dag/archive/master.zip.
There was a problem hiding this comment.
Since the other examples use a commit, and this prevents changes from breaking the test, I've updated to use the head commit for now.
kevin85421
approved these changes
Jun 21, 2023
Yeah this has been tested manually. |
shrekris-anyscale
approved these changes
Jun 21, 2023
|
This YAML file is not included in CI. Merge it. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…#1178) Change runtime env for e2e autoscaling test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Change the repo used for the runtime env for the autoscaling e2e test to ray-project/test_dag.
Related issue number
Checks