Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RayService] Update docs to use multi-app #1179

Merged
merged 8 commits into from
Jun 23, 2023
Merged

[RayService] Update docs to use multi-app #1179

merged 8 commits into from
Jun 23, 2023

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Jun 21, 2023 •
edited

Why are these changes needed?

Make some small changes to the RayService docs so that it matches with the new multi-application sample rayservice yaml file.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

cindyz added 2 commits June 21, 2023 18:01
update ray service docs
d3a7a9b 
Signed-off-by: cindyz <cindyz@anyscale.com>
update
d99b424 
Signed-off-by: cindyz <cindyz@anyscale.com>
@zcin zcin marked this pull request as ready for review June 21, 2023 18:31
update
a2e4f86 
Signed-off-by: cindyz <cindyz@anyscale.com>
kevin85421
kevin85421 reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This doc uses KubeRay v0.5.0 which does not support multi-app.
  2. Add some sections for "in-place update" and "zero downtime upgrade". (Update: the doc has in-place update example.)
  3. Explain the configurations in ray_v1alpha1_rayservice.yaml.

docs/guidance/rayservice.md Outdated Show resolved Hide resolved
docs/guidance/rayservice.md Outdated Show resolved Hide resolved
docs/guidance/rayservice.md Outdated Show resolved Hide resolved
docs/guidance/rayservice.md Outdated Show resolved Hide resolved
kevin85421
kevin85421 reviewed Jun 22, 2023
View reviewed changes
docs/guidance/rayservice.md Show resolved Hide resolved
docs/guidance/rayservice.md
@@ -131,15 +135,15 @@ $ kubectl port-forward service/rayservice-sample-head-svc 8265
```
Access the dashboard using a web browser at `localhost:8265`.

### Update Ray Serve Deployment Graph
### Update Ray Serve config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users may not know this is equivalent to "In-place update for Ray Serve applications".

zcin and others added 4 commits June 22, 2023 12:45
@zcin @kevin85421
Update docs/guidance/rayservice.md
fd9e436 
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin @kevin85421
Update docs/guidance/rayservice.md
9822206 
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin @kevin85421
Update docs/guidance/rayservice.md
edecfa0 
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin @kevin85421
Update docs/guidance/rayservice.md
9ab39ec 
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
Copy link
Contributor Author

zcin commented Jun 22, 2023

2. Add some sections for "in-place update" and "zero downtime upgrade". (Update: the doc has in-place update example.)

Can we add this separately? We can track this item in the Serve-Kuberay tasks, my main goal here is to make sure this doc is consistent with the new ray_v1alpha1_rayservice.yaml

@kevin85421
Copy link
Member

Can we add this separately? We can track this item in the Serve-Kuberay tasks, my main goal here is to make sure this doc is consistent with the new ray_v1alpha1_rayservice.yaml

Sure. Would you mind opening an issue to track the progress? Thanks!

address comments
90bdefc 
Signed-off-by: cindyz <cindyz@anyscale.com>
@zcin
Copy link
Contributor Author

zcin commented Jun 22, 2023

Can we add this separately? We can track this item in the Serve-Kuberay tasks, my main goal here is to make sure this doc is consistent with the new ray_v1alpha1_rayservice.yaml

Sure. Would you mind opening an issue to track the progress? Thanks!

@kevin85421 Created #1184!

@kevin85421 kevin85421 merged commit ecd1539 into ray-project:master Jun 23, 2023
19 of 20 checks passed
@zcin zcin deleted the multi-app-docs branch August 25, 2023 17:35
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@zcin
[RayService] Update docs to use multi-app (ray-project#1179)
b1235a4 
Update docs to use multi-app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcin @kevin85421