Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayService] Stable Diffusion example #1181

Merged
merged 43 commits into from
Jun 23, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jun 21, 2023

Why are these changes needed?

  1. docs/guidance/aws-eks-gpu-cluster.md: Most content here is the same as https://github.com/ray-project/aviary/blob/master/docs/kuberay/deploy-on-eks.md.

  2. Update MobileNet doc and YAML to encourage users to use the nightly KubeRay operator.

  3. An example for Stable Diffusion

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! I left some comments.

docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/stable-diffusion-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/stable-diffusion-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/stable-diffusion-rayservice.md Show resolved Hide resolved
kevin85421 and others added 9 commits June 22, 2023 10:56
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
@@ -10,7 +10,8 @@ kind create cluster --image=kindest/node:v1.23.0

## Step 2: Install KubeRay operator

Follow [this document](../../helm-chart/kuberay-operator/README.md) to install the latest stable KubeRay operator via Helm repository.
Follow [this document](../../helm-chart/kuberay-operator/README.md) to install the nightly KubeRay operator via
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zcin

docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/stable-diffusion-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/stable-diffusion-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/stable-diffusion-rayservice.md Outdated Show resolved Hide resolved
kevin85421 and others added 2 commits June 22, 2023 21:13
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
kevin85421 and others added 11 commits June 22, 2023 21:15
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
kevin85421 and others added 2 commits June 23, 2023 10:35
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
kevin85421 and others added 3 commits June 23, 2023 10:40
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my comments! This change looks great!

docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
docs/guidance/aws-eks-gpu-cluster.md Outdated Show resolved Hide resolved
kevin85421 and others added 4 commits June 23, 2023 10:48
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
@kevin85421
Copy link
Member Author

cc @shrekris-anyscale I have relocated the installation instructions for the NVIDIA device plugin to the appropriate location. Thanks! a071fe3

@shrekris-anyscale
Copy link
Contributor

I have relocated the installation instructions for the NVIDIA device plugin to the appropriate location. Thanks!

Awesome, thanks! This change looks ready to merge.

@kevin85421 kevin85421 merged commit c3f3736 into ray-project:master Jun 23, 2023
18 of 20 checks passed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants