Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy manifests for apiserver #119

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jan 15, 2022

Why are these changes needed?

With this change, user can easily deploy the kuberay apiserver.

Related issue number

resolve #88

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@wilsonwang371
Copy link
Collaborator

wilsonwang371 commented Jan 18, 2022

kuberay-apiserver is deployed together with kuberay-operator, right? Are we going to make a unified Makefile later?

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jan 18, 2022

kuberay-apiserver is deployed together with kuberay-operator, right?

Yes. We should provide a kuberay control plane deployment guidance. It's documented in #114

Are we going to make a unified Makefile later?

I think we don't need a unified Makefile since they are different modules now.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jan 19, 2022

Let's merge this one once #126 and #127 are merged

@wilsonwang371
Copy link
Collaborator

/LGTM

@Jeffwan Jeffwan merged commit 264ce0f into ray-project:master Jan 21, 2022
@Jeffwan Jeffwan deleted the support_apiserver_deployment branch January 21, 2022 03:59
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][backend] Prepare Docker image and kubernetes manifest for service
2 participants