[Bug] KubeRay tries to create ClusterRoleBinding when singleNamespaceInstall and rbacEnable are set to true #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @anshulomar would you mind reviewing this PR? |
anshulomar
approved these changes
Jun 27, 2023
Thanks @kevin85421 . Changes look good to me. Approved. |
architkulkarni
approved these changes
Jun 27, 2023
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…Install and rbacEnable are set to true (ray-project#1190) KubeRay tries to create ClusterRoleBinding when singleNamespaceInstall and rbacEnable are set to true
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RBAC files
leader_election_role.yaml/leader_election_rolebinding.yaml=> Role / RoleBinding for leader electionrole.yaml/rolebinding.yaml=> ClusterRole / ClusterRoleBinding for KubeRay operator to create Kubernetes resources for custom resourcesmultiple_namespaces_role.yaml/multiple_namespaces_rolebinding.yaml=> Role / RoleBinding in multiple namespaces for KubeRay operator to create Kubernetes resources for custom resourcesTest: Firstly, I wanted to try https://github.com/helm-unittest/helm-unittest, but it turned out to be not as versatile as expected.
Related issue number
Closes #1186
Checks