[Doc] Improve RayService doc #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/guidance/rayservice.md
Outdated
| * Ray 2.0 or newer. | ||
| This guide focuses solely on the Ray Serve multi-application API, which is available starting from Ray version 2.4.0. | ||
|
|
||
| * Ray 2.4.0 or newer. | ||
| * KubeRay 0.6.0 or newer. |
There was a problem hiding this comment.
On this line, let's specify that the nightly will work too.
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
| Finally, the old RayCluster will be terminated. | ||
|
|
||
| There are certain exceptions that will not trigger a zero downtime upgrade. | ||
| Currently, only the fields managed by Ray Autoscaler, such as `replicas` and `scaleStrategy.workersToDelete`, will not trigger a zero downtime upgrade. |
There was a problem hiding this comment.
Ideally we can write down the entire list of such fields. Are there too many to list, or are we worried that they'll frequently change?
There was a problem hiding this comment.
replicas and scaleStrategy.workersToDelete are the only two exceptions at this moment.
There was a problem hiding this comment.
I will merge this PR and cut a release branch. If you have any further comments, we can address them later.
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Improve RayService doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks