[CI] Add kind-in-Docker test to Buildkite CI
#1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
kevin85421
reviewed
Jul 17, 2023
kevin85421
approved these changes
Jul 17, 2023
scripts/install-docker.sh
Outdated
| export LANG=en_US.UTF-8 | ||
|
|
||
| apt-get update -qq && apt-get upgrade -qq | ||
| apt-get install -y -qq \ |
There was a problem hiding this comment.
Are these dependencies necessary for Docker installation?
There was a problem hiding this comment.
It would be beneficial to determine which dependencies are necessary and which are not. If merging this pull request is not time-sensitive, we can allocate some time to investigate this further.
There was a problem hiding this comment.
Makes sense -- as far as timing is concerned we would just need it before the 0.6.0 release, since this issue depends on it: #1199
There was a problem hiding this comment.
Fixed fd0b35e
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
Interesting failure here: https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/1044#018965e0-a40b-4f67-8c65-c763c33adbc0/129-325 Somehow a |
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
Compatibility test failure unrelated, merging. |
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Jul 20, 2023
This PR adds a Buildkite CI test that verifies that a kind cluster can be launched. This is a prerequisite for running end-to-end KubeRay tests in CI, so it makes sense to merge this PR even though KubeRay functionality isn't being tested yet. The PR uses the support added in ray-project/rayci#14. Related issue number Closes ray-project#1203 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Jul 20, 2023
This PR adds a Buildkite CI test that verifies that a kind cluster can be launched. This is a prerequisite for running end-to-end KubeRay tests in CI, so it makes sense to merge this PR even though KubeRay functionality isn't being tested yet. The PR uses the support added in ray-project/rayci#14. Related issue number Closes ray-project#1203 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
kevin85421
added a commit
that referenced
this pull request
Jul 20, 2023
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
This PR adds a Buildkite CI test that verifies that a kind cluster can be launched. This is a prerequisite for running end-to-end KubeRay tests in CI, so it makes sense to merge this PR even though KubeRay functionality isn't being tested yet. The PR uses the support added in ray-project/rayci#14. Related issue number Closes ray-project#1203 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a Buildkite CI test that verifies that a
kindcluster can be launched. This is a prerequisite for running end-to-end KubeRay tests in CI, so it makes sense to merge this PR even though KubeRay functionality isn't being tested yet.The PR uses the support added in ray-project/rayci#14.
Related issue number
Closes #1203
Checks