Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Develop Ray Serve Python script on KubeRay #1250

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

Related issue number

Closes #1176

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some minor comments.

Near the beginning, it would be good to have some sort of summary like
"In this tutorial, you will learn how to easily debug your RayService by manually running a Ray Serve script against a RayCluster. This is a useful strategy for debugging a RayService because (... you can either locally using kind or on a remote cluster, or other reasons...)"

I'm guessing that compared to RayService, the iteration speed is faster with this approach? Or it's easier to see the underlying error message?


Many RayService issues are related to the Ray Serve Python scripts.
We strongly recommend that users develop and test their Ray Serve scripts in a RayCluster using the same Ray image before deploying them to a RayService.
In this tutorial, we will show you how to develop [ray-service.mobilenet.yaml](https://github.com/ray-project/kuberay/blob/master/ray-operator/config/samples/ray-service.mobilenet.yaml).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to add a 1 sentence description of what mobilenet is and why we're using it in the tutorial

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: 638d7bc

docs/guidance/rayserve-dev-doc.md Outdated Show resolved Hide resolved
docs/guidance/rayserve-dev-doc.md Outdated Show resolved Hide resolved
kevin85421 and others added 3 commits July 18, 2023 10:43
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
@kevin85421
Copy link
Member Author

"In this tutorial, you will learn how to easily debug your RayService by manually running a Ray Serve script against a RayCluster. This is a useful strategy for debugging a RayService because (... you can either locally using kind or on a remote cluster, or other reasons...)"

Updated: f656a58

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and the intro is very clear now!

@kevin85421 kevin85421 merged commit e9a2698 into ray-project:master Jul 18, 2023
19 of 20 checks passed
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Jul 20, 2023
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Jul 20, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] How to develop Ray Serve Python script on KubeRay?
2 participants