Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Publish KubeRay operator / apiserver images to Quay #1307

Merged
merged 8 commits into from
Aug 10, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Aug 9, 2023

Why are these changes needed?

if: contains(fromJson('["refs/heads/master"]'), github.ref)

Because I am not a collaborator of this GitHub repo, I cannot read the secrets of this repo. Hence, we will not log in to either DockerHub or Quay for PR. We will only log in to the image registries after the PR is merged into the master branch.

Related issue number

#1133: We can close the issue if the PR works well after merge.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

We can only verify this PR after it is merged.

@kevin85421 kevin85421 marked this pull request as ready for review August 9, 2023 23:02
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@kevin85421 kevin85421 merged commit 4f85055 into ray-project:master Aug 10, 2023
21 checks passed
@kevin85421
Copy link
Member Author

This PR works well! Check https://quay.io/organization/kuberay for more details!

blublinsky pushed a commit to blublinsky/kuberay that referenced this pull request Aug 15, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…#1307)

Publish KubeRay operator / apiserver images to Quay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants