[CI] Install kuberay operator in buildkite test #1308
Conversation
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
.buildkite/kind-in-docker.yml
Outdated
| - popd | ||
|
|
||
| - pushd helm-chart/kuberay-operator | ||
| - helm install kuberay-operator --set image.repository=kuberay/operator --set image.tag=nightly . |
There was a problem hiding this comment.
You can also consider using the --wait option with Helm CLI (https://helm.sh/docs/helm/helm_install/) because kubectl wait isn't a smart command. Relying solely on kubectl wait might introduce flakiness. A lot of flakiness in KubeRay CI was introduced by kubectl wait. You can refer #618 for some examples.
In this PR, what will happen if the CI pipeline executes kubectl wait after the helm install command but before the KubeRay operator Pod is created? I guess it will report error.
There was a problem hiding this comment.
Good point, let me switch to helm --wait.
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
.buildkite/kind-in-docker.yml
Outdated
|
|
||
| # Install KubeRay operator | ||
| - pushd ray-operator | ||
| - IMG=kuberay/operator:nightly make docker-build |
There was a problem hiding this comment.
Sure, I guess that will skip the unit tests and make the test run faster. Any other reason? Let me go ahead and make that change
There was a problem hiding this comment.
I guess that will skip the unit tests and make the test run faster.
yes
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
This PR extends the basic kind-in-docker test to install the Kuberay operator. --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
This PR extends the basic kind-in-docker test to install the Kuberay operator. --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Why are these changes needed?
This PR extends the basic
kind-in-docker test to install the Kuberay operator.Related issue number
Checks