[CI] Run sample job YAML tests in buildkite #1315
Conversation
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
tests/framework/utils.py
Outdated
| DEFAULT_KIND_CONFIG = REPO_ROOT.joinpath("tests/framework/config/kind-config.yaml") | ||
|
|
||
| # Decide the config based on the environment | ||
| if os.getenv("BUILDKITE_ENV", default="") == "true": |
There was a problem hiding this comment.
Why do we need a new kind config?
There was a problem hiding this comment.
The new part of the config is copied from https://github.com/ray-project/ray/pull/22035/files#diff-cbbac00da1880527c8b203aeb03a1d3c492610ee1fc97f868392589c5b831893. I'm not sure about the technical details here, but it's necessary to get kubectl to work in buildkite.
I'm not sure if it has any ill effects for users who want to run the test locally, so to be safe I just made another config file.
There was a problem hiding this comment.
Got it. We can figure this out in the future.
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
Not working yet so I'll mark as draft |
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
The Buildkite sample rayjob YAML test passed and the test logs are as expected: https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/1249#0189e5e3-9193-4717-8edd-c8c1bdc7ea3a/237-2560 |
Sets up the Buildkite CI pipeline to test the RayJob sample YAML files using kind. Related issue number Closes ray-project#1246 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sets up the Buildkite CI pipeline to test the RayJob sample YAML files using kind. Related issue number Closes ray-project#1246 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sets up the Buildkite CI pipeline to test the RayJob sample YAML files using kind. Related issue number Closes ray-project#1246 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Why are these changes needed?
Sets up the Buildkite CI pipeline to test the RayJob sample YAML files using
kind.Related issue number
Closes #1246
Checks