-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update latest ray version 2.5.0 -> 2.6.3 #1320
[CI] Update latest ray version 2.5.0 -> 2.6.3 #1320
Conversation
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@@ -307,53 +307,13 @@ jobs: | |||
with: | |||
ray_version: 1.13.0 | |||
|
|||
test-compatibility-2_1_0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff algorithm got confused, I just deleted 2.1-2.3 and added one for 2.6.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update all YAML files to 2.6.2? You can refer to #1151. Thanks!
Sure, let me wait for 2.6.3 to come out (probably today) |
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@kevin85421 Done, please take a look |
Merge branch 'master' of https://github.com/ray-project/kuberay into update-latest-rayversion-ci
.github/workflows/test-job.yaml
Outdated
@@ -427,13 +387,13 @@ jobs: | |||
with: | |||
ray_version: nightly | |||
|
|||
sample-yaml-config-test-2_5_0: | |||
sample-yaml-config-test-2_6_2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.6.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup let me update it
@@ -0,0 +1,18 @@ | |||
# RayJob Batch Inference Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I accidentally added file to git, let me remove it
…update-latest-rayversion-ci Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@kevin85421 it's expected that https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/1340#018a0039-6a6e-4187-bf7c-ed206f90b4bb/238-2911 will fail because it's a bug you fixed recently (after 0.6.0: #1332), right? In that case, I'll skip it for the latest-release test. Actually, why do we need to test sample YAMLs from the tip of master against the latest release? Isn't it enough to test against the tip of the master branch? |
Yes, sorry for the inconvenience. I forgot to rebase with the master branch before merging #1332.
We also need to test sample YAMLs with the latest release. Since most users utilize the latest release, it's crucial to ensure they don't encounter issues when running the sample YAMLs with it. |
…update-latest-rayversion-ci
Update all files to Ray version 2.6.3 as in [2.5.0 Release] Change version numbers 2.4.0 -> 2.5.0 ray-project#1151 Update the Ray version used in the sample Job yaml test to Ray 2.6.2 and remove old ray versions that we don't guarantee compatibility with. This reduces costs and reduces the impact of flaky tests. We support the last three Ray stable versions and the last 1.x Ray version. --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Why are these changes needed?
Related issue number
Checks