Upgrade to Go 1.19 #1325
Merged
Upgrade to Go 1.19 #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Aug 13, 2023
| @@ -4,7 +4,4 @@ | |||
| export DEBIAN_FRONTEND=noninteractive | |||
| export TZ=America/Los_Angeles | |||
|
|
|||
| apt-get update -qq && apt-get upgrade -qq | |||
There was a problem hiding this comment.
In .buildkite/test-rayjob-sample-yamls.yml, a curl command is executed before install-docker.sh, so there's no need to install curl again.
kevin85421
commented
Aug 13, 2023
| @@ -60,7 +60,9 @@ | |||
|
|
|||
| # Install python 3.10 and pip | |||
| - apt-get update | |||
| - apt-get install -y python3.10 python3-pip | |||
There was a problem hiding this comment.
apt-get install -y python3-pip will report "error: externally-managed-environment" after I upgrade the image to golang:1.19.
|
cc @anishasthana @blublinsky would you mind taking a look? Thx! |
architkulkarni
approved these changes
Aug 14, 2023
tedhtchang
reviewed
Aug 14, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/ray-project/kuberay/apiserver | |||
|
|
|||
| go 1.17 | |||
| go 1.19 | |||
There was a problem hiding this comment.
@kevin85421 may need to update the go version in the table https://github.com/ray-project/kuberay/blob/master/apiserver/DEVELOPMENT.md#kuberay-api-server-user-guide
4 tasks
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 15, 2023
Upgrade to Go 1.19
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 15, 2023
Upgrade to Go 1.19
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 22, 2023
Upgrade to Go 1.19
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 28, 2023
Upgrade to Go 1.19
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 28, 2023
Upgrade to Go 1.19
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 29, 2023
Upgrade to Go 1.19
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 29, 2023
Upgrade to Go 1.19
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Upgrade to Go 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
crd:trivialVersionsis deprecated in controller-tool v0.7.0. See ⚠ bump to kubernetes 1.22.1, remove support for legacy v1beta1 CRDs and webhooks kubernetes-sigs/controller-tools#607 for more details.go.mod/go.sum: Updategolang:1.17togolang:1.19ingo.mod, and then run thego mod tidycommand to add missing modules and remove unused ones.Related issue number
Checks