Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[services] Add text ml rayservice yaml #1402

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Sep 7, 2023

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: cindyz <cindyz@anyscale.com>
@zcin zcin requested a review from kevin85421 September 7, 2023 18:48
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zcin
Copy link
Contributor Author

zcin commented Sep 7, 2023

  1. What's the difference between text_ml and https://github.com/ray-project/serve_config_examples/tree/master/text_summarizer?
  2. Is torch necessary? torch is not imported explicitly in https://github.com/ray-project/serve_config_examples/blob/master/text_ml.py.
  1. It is a model composition application, there are two separate deployments in one application, Translator and Summarizer
  2. torch is required

@kevin85421 kevin85421 merged commit 39ed913 into ray-project:master Sep 7, 2023
19 of 21 checks passed
z103cb pushed a commit to z103cb/kuberay that referenced this pull request Sep 11, 2023
[services] Add text ml rayservice yaml
z103cb pushed a commit to z103cb/kuberay that referenced this pull request Sep 11, 2023
[services] Add text ml rayservice yaml
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
[services] Add text ml rayservice yaml
@zcin zcin deleted the text-ml-yaml branch November 16, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants