[Feature][RayJob] Use RayContainerIndex instead of 0 (#1397) #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep, this will be great. |
rueian
force-pushed
the
feat-rayjob-ray-container-index
branch
from
771d390
to
55469db
Compare
|
Updated. BTW, Is there any way for contributors to access the above buildkite result? I can only see this: |
kevin85421
reviewed
Sep 16, 2023
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
|
The RayService e2e tests are known to be flaky. It has no relationship with this PR. Merge. |
kevin85421
changed the title
I will figure this out next week. I am not sure how to get the buildkite's access. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…#1427) Use Use RayContainerIndex instead of 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
RayContainerIndexinray-operator/controllers/ray/rayjob_controller.goto fix #1397Hi @kevin85421,
I currently leave the
rayjob_controller_unit_test.gountouched so that we can make sureRayContainerIndexis 0. Do you think we should change the usage of0toRayContainerIndexinrayjob_controller_unit_test.goas well?