Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Redirect users to Ray website #1431

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review September 17, 2023 23:09
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through and adding the individual links! Instead of deleting the old content I would prefer to leave it up (together with the link and warning that it will be deleted) to minimize disruption, at least for one release. What do you think?

But if we already decided on a process to migrate the docs, we should stick to the process.

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because I don’t have a strong preference on how we handle the deletion

@kevin85421
Copy link
Member Author

I have rewritten a lot of documents when I migrate them to the Ray repository. In addition, there are also some updates that only exist in the Ray repository. It will be better to keep only one source of the truth. Merge.

@kevin85421 kevin85421 merged commit dfdc51a into ray-project:master Sep 20, 2023
20 of 21 checks passed
z103cb pushed a commit to z103cb/kuberay that referenced this pull request Sep 20, 2023
[release] Redirect users to Ray website
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
[release] Redirect users to Ray website
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
[release] Redirect users to Ray website
kevin85421 added a commit that referenced this pull request Oct 17, 2023
[release] Redirect users to Ray website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants