Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRD] Set maxDescLen to 0 #1449

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Sep 26, 2023

Why are these changes needed?

In ETCD, the maximum allowable size for any request is 1.5 MB. The size of the request may increase whenever new fields are exposed or the CRD versions are upgraded. Without the PR, KubeRay CRDs' sizes are:

Screen Shot 2023-09-25 at 5 15 04 PM

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
Screen Shot 2023-09-25 at 5 15 43 PM

@kevin85421 kevin85421 marked this pull request as ready for review September 26, 2023 00:16
@kevin85421 kevin85421 merged commit 96c4d66 into ray-project:master Sep 26, 2023
21 of 22 checks passed
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
kevin85421 added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants