Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created HA example for API server #1461

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

There is a great document on Ray cluster HA with KubeRay https://docs.ray.io/en/master/cluster/kubernetes/user-guides/kuberay-gcs-ft.html. This PR shows how to do this using an API server.
It also implements changes to the API cluster to support this

The PR also provides step-by-step instructions for creating and testing the HA Ray cluster using the API server

Related issue number

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • [x ] Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

blublinsky commented Sep 29, 2023

@z103cb, @tedhtchang, @anishasthana please take a look
cc: @kevin85421

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit picks around spelling and not so obvious steps. Otherwise this is LGTM.

apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Show resolved Hide resolved
apiserver/HACluster.md Show resolved Hide resolved
apiserver/HACluster.md Show resolved Hide resolved
@blublinsky
Copy link
Contributor Author

@tedhtchang. Can you take a look as well

apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
apiserver/HACluster.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction in the HACluster.md was very helpful to verify the PR. I found some spells but the PR LGTM. Thank you.

@blublinsky
Copy link
Contributor Author

@kevin85421 can you. please, merge

apiserver/HACluster.md Outdated Show resolved Hide resolved
@blublinsky
Copy link
Contributor Author

@kevin85421 still waiting for you to merge

@blublinsky
Copy link
Contributor Author

@tedhtchang looks like you have not approved this yet

@z103cb
Copy link
Contributor

z103cb commented Oct 10, 2023

I am waiting for this PR to be merged so I can update this two other PRs: #1460 and #1438

Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@blublinsky
Copy link
Contributor Author

@kevin85421 ?

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this PR, but two folks from IBM have approved it. Stamp.

@kevin85421 kevin85421 self-assigned this Oct 11, 2023
@kevin85421 kevin85421 merged commit 83f1df7 into ray-project:master Oct 11, 2023
21 of 22 checks passed
@blublinsky blublinsky deleted the apiserver-HA branch October 16, 2023 10:54
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants