Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove miniReplicas in raycluster-cluster.yaml #1473

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

evalaiyc98
Copy link
Contributor

Why are these changes needed?

Clean and high readability code is easier to maintain and less prone to introducing bugs. This enhances the long-term sustainability of the project.
This change is to cleanup the KubeRay helm chart and remove a typo.

Related issue number

#1472
#1106 (comment)

Checks

$ git diff --cached | cat
diff --git a/helm-chart/ray-cluster/templates/raycluster-cluster.yaml b/helm-chart/ray-cluster/templates/raycluster-cluster.yaml
index 0c13e86..c080720 100644
--- a/helm-chart/ray-cluster/templates/raycluster-cluster.yaml
+++ b/helm-chart/ray-cluster/templates/raycluster-cluster.yaml
@@ -110,8 +110,8 @@ spec:
       {{- end }}
     {{- end }}
     replicas: {{ $values.replicas }}
-    minReplicas: {{ $values.minReplicas | default (default 0 $values.miniReplicas) }}
-    maxReplicas: {{ $values.maxReplicas | default (default 2147483647 $values.maxiReplicas) }}
+    minReplicas: {{ $values.minReplicas | default 0 }}
+    maxReplicas: {{ $values.maxReplicas | default 2147483647 }}
     groupName: {{ $groupName }}
     template:
       spec:
@@ -185,8 +185,8 @@ spec:
       {{- end }}
     {{- end }}
     replicas: {{ .Values.worker.replicas }}
-    minReplicas: {{ .Values.worker.minReplicas | default (default 0 .Values.worker.miniReplicas) }}
-    maxReplicas: {{ .Values.worker.maxReplicas | default (default 2147483647 .Values.worker.maxiReplicas) }}
+    minReplicas: {{ .Values.worker.minReplicas | default 0 }}
+    maxReplicas: {{ .Values.worker.maxReplicas | default 2147483647 }}
     groupName: {{ .Values.worker.groupName }}
     template:
       spec:



$ helm lint
==> Linting .

1 chart(s) linted, 0 chart(s) failed
  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@evalaiyc98
Copy link
Contributor Author

To confirm that the operation produces the expected outcomes, here is a screenshot from the local machine.
As we can see, the Worker Group Specs match our expectations, where minReplicas is 0 and maxReplicas is 2147483647.
raycluster-cluster

@kevin85421 kevin85421 self-assigned this Oct 11, 2023
@kevin85421 kevin85421 merged commit 2ae7574 into ray-project:master Oct 11, 2023
23 checks passed
@evalaiyc98 evalaiyc98 deleted the remove-typo branch October 12, 2023 01:09
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
Remove miniReplicas in raycluster-cluster.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants