Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for API Server monitoring #1479

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Add documentation for API Server monitoring #1479

merged 7 commits into from
Oct 13, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

This provides documentation for setting up monitoring for KubeRay API server

Related issue number

closes #1311

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb, @tedhtchang , please take a look.

cc @kevin85421

tedhtchang
tedhtchang reviewed Oct 12, 2023
View reviewed changes
apiserver/Monitoring.md Outdated Show resolved Hide resolved
tedhtchang
tedhtchang reviewed Oct 12, 2023
View reviewed changes
apiserver/Monitoring.md Outdated Show resolved Hide resolved
tedhtchang
tedhtchang reviewed Oct 12, 2023
View reviewed changes
apiserver/Monitoring.md Outdated Show resolved Hide resolved
z103cb
z103cb reviewed Oct 12, 2023
View reviewed changes
apiserver/Monitoring.md Outdated Show resolved Hide resolved
z103cb
z103cb reviewed Oct 12, 2023
View reviewed changes
apiserver/Monitoring.md Outdated Show resolved Hide resolved
z103cb
z103cb approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is LGTM.

@kevin85421
Copy link
Member

Is this ready to merge?

tedhtchang
tedhtchang approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@kevin85421 kevin85421 merged commit 80ce664 into ray-project:master Oct 13, 2023
23 checks passed
@blublinsky blublinsky deleted the apiserver-metrics branch October 16, 2023 10:54
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
@blublinsky @kevin85421
Add documentation for API Server monitoring (ray-project#1479)
811b937 
Add documentation for API Server monitoring
kevin85421 added a commit that referenced this pull request Oct 17, 2023
@kevin85421
Add documentation for API Server monitoring (#1479) (#1532)
420cb9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedhtchang tedhtchang tedhtchang approved these changes

@kevin85421 kevin85421 kevin85421 approved these changes

@z103cb z103cb z103cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] KubeRay API Server + Prometheus metrics documentation
4 participants
@blublinsky @kevin85421 @tedhtchang @z103cb