[Feature][Observability] Scrape Autoscaler and Dashboard metrics #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
added a commit
to kevin85421/kuberay
that referenced
this pull request
Oct 17, 2023
kevin85421
added a commit
that referenced
this pull request
Oct 17, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray exposes Prometheus metrics through three endpoints: 8080, 44217 (for autoscaler metrics), and 44227 (for dashboard metrics). See /tmp/ray/prom_metrics_service_discovery.json on the head Pod for more details. Some Grafana panels embedded in the Ray dashboard require metrics from Autoscaler. Hence, the panel may show "No data".
This PR scrapes metrics from all 8080, 44217, and 44227, so the panel will not show "No data" anymore.
Related issue number
Closes #1487
Checks