extended job APIs #1537
Merged
extended job APIs #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It requires rebasing |
Signed-off-by: Boris Lublinsky <blublinsky@hotmail.com>
|
@z103cb, @astefanutti, pls take a look cc: @kevin85421 |
z103cb
reviewed
Oct 17, 2023
There was a problem hiding this comment.
There are two things, that I think should be included in this PR:
- update of the README.md with examples
- the func ValidateCreateJobRequest(request *api.CreateRayJobRequest) error { function should be enhanced to validate the required fields in the ray submitter is present in the request. I would go as far as making the object required if a cluster selector is used.
Implemented check in util/job.go |
|
Add documentation on how to use it in Readme |
z103cb
reviewed
Oct 18, 2023
|
@astefanutti all ready for you |
astefanutti
reviewed
Oct 18, 2023
kevin85421
approved these changes
Oct 19, 2023
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Nov 2, 2023
kevin85421
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In the Job APIs for the apiserver added job submitter parameters. This fixes the problem of Python/Ray version mismatch in the case of existing Ray cluster
Related issue number
Checks