Allow to install and remove operator via scripts #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
approved these changes
Oct 20, 2023
tests/compatibility-test.py
Outdated
| @@ -83,7 +74,7 @@ def setUpClass(cls): | |||
| CONST.RAY_IMAGE_KEY: ray_image, | |||
There was a problem hiding this comment.
Should we remove image_dict here?
tests/compatibility-test.py
Outdated
| @@ -230,7 +221,7 @@ def setUpClass(cls): | |||
| CONST.RAY_IMAGE_KEY: ray_image, | |||
There was a problem hiding this comment.
Should we remove image_dict here?
jiripetrlik
force-pushed
the
custom-install-cleanup-scripts
branch
2 times, most recently
from
a7e7446
to
72931eb
Compare
|
@kevin85421 Thank you for the review! Both comments should be fixed. Can we merge? |
|
FYI: @sutaakar |
|
Rerun the flaky tests. I will merge this PR after they pass. |
|
@jiripetrlik Could you fix the CI errors? |
jiripetrlik
force-pushed
the
custom-install-cleanup-scripts
branch
from
72931eb
to
cf499b6
Compare
|
@kevin85421 |
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Nov 2, 2023
kevin85421
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It allows to install and uninstall Kuberay operator using scripts. It will be useful for environments where it is not possible to use Helm.