-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RayJob]: Always use target RayCluster image as default RayJob submitter image #1548
Conversation
d131e4e
to
9083b53
Compare
@kevin85421 @z103cb @blublinsky for your review, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Image: image, | ||
Name: "ray-job-submitter", | ||
// Use the image of the Ray head to be defensive against version mismatch issues | ||
Image: rayClusterInstance.Spec.HeadGroupSpec.Template.Spec.Containers[0].Image, | ||
Resources: v1.ResourceRequirements{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
We can now remove the check in the API server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Would you mind adding some unit tests for the function?
@kevin85421 I've added a unit test and re-pushed. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
Related issue number
Closes #1547.
Checks