Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed processing of job submitter #1562

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

Fixes errors introduced by PR that added job submitter to API server

Related issue number

Checks

  • [x ] I've made sure the tests are passing.
  • Testing Strategy
    • [x ] Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb, @astefanutti please, take a look

cc @kevin85421

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apiserver/pkg/util/job.go Outdated Show resolved Hide resolved
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit 4432b78 into ray-project:master Oct 24, 2023
23 checks passed
@blublinsky blublinsky deleted the apiserver-job branch October 26, 2023 13:22
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants