Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Create release tag for ray-operator Go module #1574

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

astefanutti
Copy link
Contributor

Why are these changes needed?

Automate the creation of the release tags for the ray-operator Go module.

Related issue number

Closes #1549

Checks

I've tested it locally on my fork.

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@astefanutti
Copy link
Contributor Author

@kevin85421 could you please give it a review?

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

  • Would you mind testing it on your fork before I merge it?
  • Could you please update release.md to specify that the release manager does not need to manually push the tag?

@astefanutti
Copy link
Contributor Author

  • Would you mind testing it on your fork before I merge it?

I've tested it successfully on my fork.

  • Could you please update release.md to specify that the release manager does not need to manually push the tag?

I've updated the instructions and re-pushed. PTAL.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will test it after I merge it into the master branch.

@kevin85421 kevin85421 merged commit 7542c5e into ray-project:master Oct 26, 2023
22 of 23 checks passed
@kevin85421
Copy link
Member

I triggered the CI, merged the PR, and successfully created the tag, but I haven't tested installing the Go module yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Release Go module by release CI
2 participants