Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all deprecated HeadGroupSpec.replicas #1588

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Oct 31, 2023

in example YAMLs

Why are these changes needed?

This field has been deprecated since 0.3.0.
Related comment

Related issue number

#612

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

in example YAMLs

This field has been deprecated since 0.3.0.
[Related comment](ray-project#612 (comment))
@davidxia davidxia changed the title chore: remove all HeadGroupSpec.replicas in example YAMLs chore: remove all deprecated HeadGroupSpec.replicas Oct 31, 2023
@davidxia davidxia marked this pull request as ready for review October 31, 2023 18:20
@kevin85421 kevin85421 self-assigned this Oct 31, 2023
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kevin85421 kevin85421 merged commit 3f37a7f into ray-project:master Nov 13, 2023
22 of 23 checks passed
@davidxia davidxia deleted the patch10 branch November 15, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants