Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove HeadGroupSpec.Replicas from raycluster_types.go #1589

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

davidxia
Copy link
Contributor

Why are these changes needed?

It has been deprecated since 0.3.0.

Changes to generated files made by running cd ray-operator && make sync generate manifests.

Related issue number

closes #612

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

It has been deprecated since 0.3.0.

Changes to generated files made by running `cd ray-operator && make sync
generate manifests`.

closes ray-project#612
@davidxia davidxia marked this pull request as ready for review October 31, 2023 19:39
@kevin85421 kevin85421 self-assigned this Oct 31, 2023
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kevin85421
Copy link
Member

The CI failure has been fixed by #1590 and is not related to this PR. Proceeding with the merge.

@kevin85421 kevin85421 merged commit 7c82efe into ray-project:master Nov 14, 2023
22 of 23 checks passed
@davidxia davidxia deleted the patch11 branch November 15, 2023 17:09
blublinsky pushed a commit to blublinsky/kuberay that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] HeadGroupSpec.Replicas is unused
2 participants