Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: odd number of arguments #1594

Merged

Conversation

chenk008
Copy link
Contributor

@chenk008 chenk008 commented Nov 2, 2023

Why are these changes needed?

For now, exitOnError without keysAndValues, will cause panic: odd number of arguments passed as key-value pairs for logging. It is noisily.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm nice one!

@architkulkarni architkulkarni merged commit fa8cecb into ray-project:master Nov 2, 2023
23 checks passed
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Nov 2, 2023
For now, exitOnError without keysAndValues, will cause panic: odd number of arguments passed as key-value pairs for logging. It is noisily.

Co-authored-by: wuhua.ck <wuhua.ck@alibaba-inc.com>
kevin85421 added a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants