[RayService][Health-Check][4/n] Remove the health check for Ray Serve applications. #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
changed the title
23 tasks
architkulkarni
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#1656 has already prevented the initiation of new RayCluster preparation based on the health status of the Ray dashboard agent and Ray Serve applications. Therefore, the RayService controller now focuses solely on whether the RayCluster is ready to handle incoming traffic. This PR removes the health check for Ray Serve applications. Ray Serve applications should be managed by Ray Core and ServeController instead of KubeRay.
Related issue number
Checks
I do not update any test logic in this PR to prove that the definition of readiness is still the same and backward compatible.