Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue with jobSubmitter resources #1676

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

Resources for job submitter were assigned incorrectly, causing and error in e2e test

Resource requests aligned with resource limits

Related issue number

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • [x ] Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb fixed the resource issue that we discussed, please approve

cc: @kevin85421

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you augment the existing unit test to cover the bug ?

@blublinsky
Copy link
Contributor Author

@z103cb test expanded

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blublinsky
Copy link
Contributor Author

@kevin85421 , this one is ready to merge, I hope

@kevin85421 kevin85421 merged commit 1ec290f into ray-project:master Nov 22, 2023
24 checks passed
@blublinsky blublinsky deleted the apiserver-job branch November 22, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants