Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some bugs in e2e-test #1682

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fixed some bugs in e2e-test #1682

merged 1 commit into from
Nov 27, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

Due to original and newly introduced bugs, API server e2e test was failing

Related issue number

#1591

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • [x ] Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb @tedhtchang this fixes tmout issues in e2e tests.

cc:/ @kevin85421

z103cb
z103cb approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

astefanutti
astefanutti approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z103cb
Copy link
Contributor

z103cb commented Nov 27, 2023

@kevin85421 can you please merge this at your earliest convenience?

kevin85421
kevin85421 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only changes KubeRay API Server, so it is not related to the CI failure which is a known flaky issue.

@kevin85421 kevin85421 merged commit 71075eb into ray-project:master Nov 27, 2023
24 of 25 checks passed
@blublinsky blublinsky deleted the apiserver-e2e-test branch November 28, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@kevin85421 kevin85421 kevin85421 approved these changes

@z103cb z103cb z103cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blublinsky @z103cb @astefanutti @kevin85421