Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RayCluster Helm: Make volumeMounts and volumes optional for workers #1689

Merged

Conversation

calizarr
Copy link
Contributor

Add defaults to the above and merge otherwise

Why are these changes needed?

The current Helm chart errors out inscrutably as described here

Related issue number

Closes #1668

Checks

It's a Helm chart so I did manual testing on outputs etc.

To test, create the below file as extra-values.yaml and pass it as an argument to helm via -f:

additionalWorkerGroups:
  testGroup:
    disabled: false
    minReplicas: 0
    maxReplicas: 1
    replicas: 1
  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin85421 kevin85421 merged commit 0a3c181 into ray-project:master Nov 27, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] RayCluster Helm Chart: additionalWorkerGroups
2 participants